Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Speed up and fix graph tests #759

Merged
merged 12 commits into from
Sep 14, 2021
Merged

Speed up and fix graph tests #759

merged 12 commits into from
Sep 14, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Sep 14, 2021 •
edited
Loading

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 14, 2021 •
edited
Loading

Codecov Report

Merging #759 (6e8e614) into master (d963de7) will increase coverage by 1.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
+ Coverage   89.07%   90.20%   +1.12%     
==========================================
  Files         198      198              
  Lines       10693    10675      -18     
==========================================
+ Hits         9525     9629     +104     
+ Misses       1168     1046     -122
Flag Coverage Δ
unittests 90.20% <100.00%> (+1.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/audio/classification/cli.py 100.00% <ø> (ø)
flash/audio/speech_recognition/cli.py 100.00% <ø> (ø)
flash/graph/classification/cli.py 92.30% <ø> (+49.45%) ⬆️
flash/image/classification/cli.py 84.61% <ø> (-1.10%) ⬇️
flash/image/classification/data.py 94.11% <ø> (ø)
flash/image/detection/cli.py 100.00% <ø> (ø)
flash/image/detection/data.py 93.75% <ø> (ø)
flash/image/instance_segmentation/cli.py 100.00% <ø> (ø)
flash/image/instance_segmentation/data.py 88.23% <ø> (ø)
flash/image/keypoint_detection/cli.py 100.00% <ø> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d963de7...6e8e614. Read the comment docs.

@ethanwharris ethanwharris changed the title Speed up graph tests Speed up and fix graph tests Sep 14, 2021
@ethanwharris ethanwharris marked this pull request as ready for review September 14, 2021 22:33
@mergify mergify bot requested a review from a team September 14, 2021 22:33
@ethanwharris ethanwharris merged commit 3b88e74 into master Sep 14, 2021
@ethanwharris ethanwharris deleted the bugfix/torch_geometric branch September 14, 2021 22:51
@Borda Borda added bug / fix Something isn't working refactors & code health tests / CI Tests and continuous integration labels May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@tchaton tchaton Awaiting requested review from tchaton

Assignees
No one assigned
Labels
bug / fix Something isn't working refactors & code health tests / CI Tests and continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanwharris @Borda